[jdbc-v2] Fixes in the PreparedStatementImpl class, the initial length of the parameters is incorrectly changed in the clearParameters method #2305
Conversation
|
jielongping seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Good day, @CCweixiao! Thanks! |
…h of the parameters is incorrectly changed in the clearParameters method
Thanks a lot for the code review, I've submitted a test case for the corresponding code fix, please help me review again. @chernser |
| } | ||
|
|
||
| @Override | ||
| String compileSql(String[] segments) { |
There was a problem hiding this comment.
this is not a good practice - if someone change an original method then test will not be verifying a production code.
Please just make compileSql package private. This is ok because tests sometimes need to do so.
| } | ||
| } | ||
|
|
||
| static class TestPreparedStatementImpl extends PreparedStatementImpl { |
There was a problem hiding this comment.
please remove this class.
|
@CCweixiao thanks! |
Your suggestion was taken and the test case modifications were completed @chernser |
|
@CCweixiao can you sign the CLA |
|
4 participants
Summary
Closes #2299
Checklist
Delete items not relevant to your PR: