Skip to content

RowBinary writer for ease of serialization #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Paultagoras merged 15 commits into from
Apr 16, 2025
Merged

RowBinary writer for ease of serialization #2190

Paultagoras merged 15 commits into from
Apr 16, 2025

Conversation

@Paultagoras
Copy link
Contributor

@Paultagoras Paultagoras commented Feb 28, 2025 •
edited by chernser
Loading

Summary

  • Implements RowBinaryWriter to take data and serialize it in RowBinary format
  • Adds data type tests to validate changes

This will be used for #2171

Closes #2177

Checklist

Delete items not relevant to your PR:

@Paultagoras Paultagoras self-assigned this Feb 28, 2025
@github-actions
Copy link

github-actions bot commented Mar 31, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

@github-actions github-actions bot added the stale label Mar 31, 2025
@Paultagoras Paultagoras removed the stale label Mar 31, 2025
@Paultagoras Paultagoras marked this pull request as ready for review April 10, 2025 19:44
@mshustov mshustov requested a review from Copilot April 14, 2025 09:48
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

@Paultagoras Paultagoras linked an issue Apr 16, 2025 that may be closed by this pull request
Can not write data into table #2307
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 16, 2025

Quality Gate Passed Quality Gate passed

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.8% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

@Paultagoras Paultagoras merged commit 18ed07e into main Apr 16, 2025
25 checks passed
@Paultagoras Paultagoras deleted the row-binary-writer branch April 16, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chernser chernser chernser approved these changes

@mzitnik mzitnik Awaiting requested review from mzitnik

Assignees

@Paultagoras Paultagoras

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can not write data into table [client-v2] RowBinary writer

3 participants

@Paultagoras @chernser