Skip to content

Conversation

@Paultagoras
Copy link
Contributor

@Paultagoras Paultagoras commented Dec 17, 2024

Summary

Closes #2027
Adds a call to gather currentUser(), timezone(), and version() for the client

Checklist

Delete items not relevant to your PR:

@Paultagoras Paultagoras self-assigned this Dec 17, 2024
Copy link
Contributor

@chernser chernser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct getters

@Paultagoras Paultagoras requested a review from chernser December 17, 2024 17:14
@sonarqubecloud
Copy link

Copy link
Contributor

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment i think we should a way to disable if the user wants

@Paultagoras Paultagoras merged commit 1186ae3 into main Dec 18, 2024
61 of 62 checks passed
@Paultagoras Paultagoras deleted the add-server-context branch December 18, 2024 14:15
@chernser chernser changed the title Initial attempt at adding some server context to the client [client-v2] Initial attempt at adding some server context to the client Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[client-v2] Implement loading server context

4 participants