Skip to content

Implement Unwrap() on BlockError#1741

Merged
kavirajk merged 1 commit intoClickHouse:mainfrom
ilidemi:block-error-unwrap
Dec 25, 2025
Merged

Implement Unwrap() on BlockError#1741
kavirajk merged 1 commit intoClickHouse:mainfrom
ilidemi:block-error-unwrap

Conversation

@ilidemi
Copy link
Copy Markdown
Member

@ilidemi ilidemi commented Dec 23, 2025

Summary

Implement Unwrap() on BlockError to allow for errors.Is() traversal
Fixes #1740

Checklist

Delete items not relevant to your PR:

@ilidemi ilidemi requested a review from kavirajk December 25, 2025 18:07
Copy link
Copy Markdown
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @ilidemi

@kavirajk kavirajk merged commit c5bccc8 into ClickHouse:main Dec 25, 2025
20 of 21 checks passed
ilidemi added a commit to PeerDB-io/peerdb that referenced this pull request Jan 7, 2026
clickhouse-go has ClickHouse/clickhouse-go#1741
to help with classification
pgx has jackc/pgx#2417 to avoid getting stuck on
large numerics
prost is not yet, one buf plugin version away
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BlockError doesn't implement Unwrap()

2 participants