Add context option to append more ClientInfo to the system.query_log#1736
Merged
SpencerTorres merged 1 commit intomainfrom Dec 12, 2025
Merged
Add context option to append more ClientInfo to the system.query_log#1736SpencerTorres merged 1 commit intomainfrom
SpencerTorres merged 1 commit intomainfrom
Conversation
kavirajk
approved these changes
Dec 12, 2025
Contributor
kavirajk
left a comment
There was a problem hiding this comment.
LGTM. one minor question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientInfo is appended per-query, but it can only be set upon connection.
This PR allows users to append to it per-query. The original ClientInfo from the initial connection is unaffected, it's append-only.
Changes:
WithClientInfofunction for usage withclickhouse.ContextCommentpublic onClientInfoso users can append to it in theirclickhouse.OptionsconfigUsage
Checklist