Merged
Conversation
Before: most of the exit points in this PR returns either "EOF" or "read: EOF" without much context After: These errors are written with more context. e.g: handsake failure, ping failure, reading block failure, etc. Along with more info like connection-id, remote-address, etc. We also make sure, we wrap the original error `io.EOF` so that consumer can still use helpers like errors.Is(err, io.EOF) without any problem. Although one caveat is if any users where trying to use the actual error message like `err.Error() == "read: EOF"` that would fail now. Signed-off-by: Kaviraj <[email protected]>
chernser
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before: most of the exit points in this PR returns either
EOForread: EOFwithout much contextAfter: These errors are written with more context. e.g: handsake failure, ping failure, reading block failure, etc. Along with more info like connection-id, remote-address, etc.
We also make sure, we wrap the original error
io.EOFso that consumer can still use helpers like errors.Is(err, io.EOF) without any problem.Although one caveat is if any users where trying to use the actual error message like
err.Error() == "read: EOF"that would fail now.Related: #1464
Checklist
Delete items not relevant to your PR: