feat: OpenDB api now sets few configs passed via options#1675
Merged
Conversation
Currently, some settings passed via Options are not set in sql.DB connection in OpenDB() api. These configs include 1. MaxIdleConns 2. MaxOpenConns 3. ConnMaxLifetime Passing these configs will result in error asking user to set those manually via returned sql.DB connection. This PR fixes it by respecting those configs passed in via Options and sets in the connection before return. Makes it consistent with Open() api causing less confusion. Signed-off-by: Kaviraj <[email protected]>
SpencerTorres
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, some settings passed via
Optionsare not set insql.DBconnection inOpenDB()api. These configs includePassing these configs will result in error asking user to set those manually via returned
sql.DBconnection.This PR fixes it by respecting those configs passed in via Options and sets in the connection before return. Makes it consistent with
Open()api causing less confusion.NOTE: It's hard to write test for this one without using reflection (to interpret non-exported private fields of
sql.DB). So trusting on just existing test cases.Checklist
Delete items not relevant to your PR: