bug: headers map can be nil#1650
Merged
SpencerTorres merged 1 commit intoClickHouse:mainfrom Sep 12, 2025
Merged
Conversation
|
|
r0bobo
force-pushed
the
fix-http-protocol-header-nil-pointer
branch
from
1c86c9a to
01eb24e
Compare
SpencerTorres
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
func (h *httpConnect) createRequestWithExternalTables(ctx context.Context, query string, options *QueryOptions, headers map[string]string) (*http.Request, error)function assumes that the headers map passed into is instantiated.When testing the http protocol in our system we get
panic: assignment to entry in nil mapwhen doing writes.This change instantiates the map if it's empty to avoid that.
Checklist
Delete items not relevant to your PR: