bug: deserializing into nullable field#1649
Merged
SpencerTorres merged 4 commits intoClickHouse:fix_pr_1649from Sep 13, 2025
Merged
bug: deserializing into nullable field#1649SpencerTorres merged 4 commits intoClickHouse:fix_pr_1649from
SpencerTorres merged 4 commits intoClickHouse:fix_pr_1649from
Conversation
Merged
SpencerTorres
added a commit
that referenced
this pull request
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a reproducer of the bug here: #1648 (comment)
There are 3 commits in this PR. If you checkout the code in the second commit you will see the panic happening in the
TestArrayTupleNullableFieldPanictest.If you checkout the 3rd commit (tip of the branch) the test is fixed.
Notice how the deserialization into a nullable field that is inside a tuple causes a panic.
There are 2 tests - one using nullable field (which fails with the panic) and one which succeeds without using nullable.
Notice that the existing method
scanMapandscanSlicealready properly handle nil cases it was only missing in thisscanStruct.Checklist
Delete items not relevant to your PR: