Closed
Conversation
The Svace static analyzer (https://www.ispras.ru/en/technologies/svace/) flagged this code as suspicious: it could lead to a panic (division by zero) when data is empty.
|
|
kavirajk
reviewed
Sep 16, 2025
| } | ||
|
|
||
| nulls = make([]uint8, len(data)/col.col.Size) | ||
| if col.col.Size == 0 { |
Contributor
There was a problem hiding this comment.
can we do something like following?
size := 0
if col.col.Size != 0 {
size = len(data)/col.col.Size
}
nulls = make([]uint8, size)
Rationale being, this makes it more readable IMHO. Some additional advantages like
- Less duplication with
make() - Bit simpler control flow
- Single place to calculate the value of
size.
what do you think?
Contributor
Author
There was a problem hiding this comment.
yes, you're right! thanks!
kavirajk
reviewed
Sep 16, 2025
Contributor
kavirajk
left a comment
kavirajk
left a comment
There was a problem hiding this comment.
thanks @artemseleznev for the PR :)
Left one minor comment. Happy to merge after that.
3 tasks
Contributor
|
closing in favor of #1665. Thanks for the contribution @artemseleznev :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Svace static analyzer (https://www.ispras.ru/en/technologies/svace/) flagged this code as suspicious: it could lead to a panic (division by zero) when data is empty.