Support interface typed NamedValue binding#1633
Support interface typed NamedValue binding#1633SpencerTorres merged 8 commits intoClickHouse:mainfrom
Conversation
|
@SpencerTorres could you please help to review this change? ;) |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for interface-typed NamedValue binding in ClickHouse query parameters, addressing issue #1632. Previously, only string values were supported for named parameters, but now the driver can handle various interface{} types by formatting them appropriately.
- Removes the restriction that required string values for NamedValue parameters
- Adds formatting logic to convert interface{} values to strings using the existing format function
- Updates tests to verify both string and non-string interface values work correctly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| query_parameters.go | Implements interface value formatting for NamedValue parameters and removes related error constant |
| tests/std/query_parameters_test.go | Updates test to verify interface-typed NamedValue binding works instead of expecting an error |
| tests/query_parameters_test.go | Updates test to verify interface-typed NamedValue binding works instead of expecting an error |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
@SpencerTorres please help to review this change :) |
|
@crisismaple thanks for the contribution :) can you add short summary on CHANGELOG please? |
Summary
Support interface typed NamedValue binding issue #1632
Checklist
Delete items not relevant to your PR: