Add missing interval types#1613
Merged
SpencerTorres merged 1 commit intoClickHouse:mainfrom Jul 21, 2025
Merged
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for four missing interval types to the column parsing functionality: nanosecond, microsecond, millisecond, and quarter intervals. This extends the existing interval type support to provide more granular time precision options and quarterly time periods.
- Adds support for sub-second interval types (nanosecond, microsecond, millisecond)
- Adds support for quarterly interval type
- Maintains existing functionality for all previously supported interval types
Comment on lines
43
to
+44
| switch col.chType = t; col.chType { | ||
| case "IntervalSecond", "IntervalMinute", "IntervalHour", "IntervalDay", "IntervalWeek", "IntervalMonth", "IntervalYear": | ||
| case "IntervalNanosecond", "IntervalMicrosecond", "IntervalMillisecond", "IntervalSecond", "IntervalMinute", "IntervalHour", "IntervalDay", "IntervalWeek", "IntervalMonth", "IntervalQuarter", "IntervalYear": |
There was a problem hiding this comment.
[nitpick] The case statement has become quite long with 11 interval types. Consider using a map or slice to store supported interval types and check membership, which would improve readability and make future additions easier to maintain.
SpencerTorres
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The following missing interval types have been added:
IntervalNanosecondIntervalMicrosecondIntervalMillisecondIntervalQuarter