feat(time): Replace time.Time with time.Duration for Go type#1097
Merged
feat(time): Replace time.Time with time.Duration for Go type#1097
time.Time with time.Duration for Go type#1097Conversation
kavirajk
changed the title
time.Time with time.Duration for Go typetime.Time with time.Duration for Go type
kavirajk
changed the title
time.Time with time.Duration for Go typetime.Time with time.Duration for Go type
3 tasks
kavirajk
force-pushed
the
kavirajk/fix-time-time64-types
branch
from
f6cfd63 to
eafa8f7
Compare
ernado
approved these changes
Oct 4, 2025
Contributor
Author
|
Ah. @SpencerTorres had some opinions before merge. @SpencerTorres feel free to still review and share feedback in same PR, I will address it in the follow up PR |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently time and time64 types are treated as Go's
time.Timefor inserts and scan.This causes lots of complexity and bad UX for users.
Having coming up with "sane" zero values is super cumbersome. Plus it's going to be bad UX for developers if want to do some arithmetic on those types.
This PR converts that to more sane
time.Durationtype. This type fits naturally to CH time and time64 types.Also see this comment
Checklist
Delete items not relevant to your PR: