Skip to content

chore: update error_codes to ones from ClickHouse 25.8#1094

Merged
SpencerTorres merged 1 commit intoClickHouse:mainfrom
heavycrystal:error-codes-25_8
Sep 15, 2025
Merged

chore: update error_codes to ones from ClickHouse 25.8#1094
SpencerTorres merged 1 commit intoClickHouse:mainfrom
heavycrystal:error-codes-25_8

Conversation

@heavycrystal
Copy link
Copy Markdown
Contributor

@heavycrystal heavycrystal commented Sep 12, 2025

Summary

vibe coded wrote a script that ran SELECT DISTINCT name, code FROM system.errors ORDER BY code SETTINGS system_events_show_zero_values=1; on ClickHouse version 25.8.1.986. This was then compared against existing error_codes.go and it added new errors, marked removed errors as deprecated and kept old and new names for errors that changed name, new name first.

Also regenerated error_enum.go

Checklist

Delete items not relevant to your PR:

@heavycrystal heavycrystal changed the title update error_codes to ones from ClickHouse 25.8 chore: update error_codes to ones from ClickHouse 25.8 Sep 12, 2025
Copy link
Copy Markdown
Member

@SpencerTorres SpencerTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if all of these are used or not, and it may increase the binary size a bit. It's good to have these in sync with ClickHouse though

@SpencerTorres SpencerTorres merged commit 574559b into ClickHouse:main Sep 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants