feat: add ssh key authentication support#1075
Merged
ernado merged 3 commits intoClickHouse:mainfrom Jul 16, 2025
Merged
Conversation
3 tasks
shivanshuraj1333
force-pushed
the
feat/issues/350
branch
8 times, most recently
from
18a50b0 to
68137dd
Compare
Contributor
Author
|
@SpencerTorres need your help for this one too... |
SpencerTorres
approved these changes
Jul 16, 2025
Member
|
@ernado Security related code. I'd like to get another review on this if you can take a look. Thanks! |
ernado
requested changes
Jul 16, 2025
client.go
Outdated
| MeterProvider metric.MeterProvider | ||
|
|
||
| // SSH authentication | ||
| SSHKeyFile string // path to SSH private key file |
Collaborator
There was a problem hiding this comment.
Lets use
import (
cryptossh "golang.org/x/crypto/ssh"
)
// ...
// SSH authentication.
SSHSigner cryptossh.SignerHere to allow manually loading SSH keys from vaults/memory.
shivanshuraj1333
force-pushed
the
feat/issues/350
branch
from
68137dd to
9465fd3
Compare
shivanshuraj1333
force-pushed
the
feat/issues/350
branch
from
1b5022e to
959497c
Compare
Contributor
Author
|
@ernado I'm now making a good use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #350
Summary
adds ssh support for auth
Checklist
Delete items not relevant to your PR: