feat(client): add DialWithBuffer and ConnectWithBuffer functions #1073
Merged
SpencerTorres merged 1 commit intoClickHouse:mainfrom Jul 16, 2025
Merged
feat(client): add DialWithBuffer and ConnectWithBuffer functions #1073SpencerTorres merged 1 commit intoClickHouse:mainfrom
DialWithBuffer and ConnectWithBuffer functions #1073SpencerTorres merged 1 commit intoClickHouse:mainfrom
Conversation
|
|
rabenhorst
force-pushed
the
dial-with-buffer
branch
from
0bf6bf7 to
1d818d1
Compare
rabenhorst
changed the title
DialWithBuffer and ConnectWithBuffer functions DialWithBuffer and ConnectWithBuffer functions
rabenhorst
force-pushed
the
dial-with-buffer
branch
from
1d818d1 to
fe4e7c6
Compare
Signed-off-by: Sebastian Rabenhorst <[email protected]> Added write buffer pool using puddle Signed-off-by: Sebastian Rabenhorst <[email protected]>
rabenhorst
force-pushed
the
dial-with-buffer
branch
from
fe4e7c6 to
411474d
Compare
rabenhorst
changed the title
DialWithBuffer and ConnectWithBuffer functions DialWithBuffer and ConnectWithBuffer functions
rabenhorst
changed the title
DialWithBuffer and ConnectWithBuffer functions DialWithBuffer and ConnectWithBuffer functions
SpencerTorres
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
DialWithBufferandConnectWithBufferfunctions so buffer can be reused between clients and allocations reduced. This is especially useful when writing big payloads with new connections.Checklist
Delete items not relevant to your PR: