feat[pool]: Expose Close method to facilitate removal of broken connections#1054
Merged
ernado merged 1 commit intoClickHouse:mainfrom Jul 16, 2025
Merged
Conversation
c9aba18 to
b68972d
Compare
b68972d to
999e44b
Compare
999e44b to
add6b63
Compare
Member
|
@danieloliveira-shopify Make sure to complete the CLA in the above message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a
Closemethod to the chpool.Client struct. This function will close the underlying connection and destroy the resource from the pool.This will allow broken connections to not be put back into the pool if they are broken. The snipped below exemplifies the scenario.
Checklist
Delete items not relevant to your PR: