test(json): add e2e test for json str and array json str#1044
Merged
Conversation
1 task
SpencerTorres
force-pushed
the
fix_json_array
branch
from
bc0bbfc to
61a3a47
Compare
SpencerTorres
force-pushed
the
fix_json_array
branch
2 times, most recently
from
7312552 to
14fd5c4
Compare
SpencerTorres
force-pushed
the
fix_json_array
branch
from
14fd5c4 to
f96e659
Compare
Member
Author
|
What an incredibly challenging fight with the CI that was 💀 @ernado let me know if any of these changes were unnecessary. I had to fix some broken issues from main:
AAAAAAAAAAAAAAAA |
This will help with enumer.
Collaborator
|
I've fixed the enumer thing. Just needed to bump x/tools: dmarkham/enumer#106 |
ernado
approved these changes
Feb 18, 2025
Collaborator
|
Thank you for fixing the CI! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As suggested in #1043 (comment), here are some e2e tests for
JSONandArray(JSON)using theColJSONStrtypeChecklist