fix(compressor): fixing an overflow that could potentially smuggle query in from data#1041
Merged
SpencerTorres merged 2 commits intomainfrom Feb 14, 2025
Merged
fix(compressor): fixing an overflow that could potentially smuggle query in from data#1041SpencerTorres merged 2 commits intomainfrom
SpencerTorres merged 2 commits intomainfrom
Conversation
SpencerTorres
requested changes
Feb 14, 2025
Member
SpencerTorres
left a comment
SpencerTorres
left a comment
There was a problem hiding this comment.
Appreciate the info, given the potential problems this causes I've added a comment that links back to this PR, just so it doesn't get accidentally removed in the future.
I also removed the capacity check since the slice would be appropriately resized in the prior logic
SpencerTorres
approved these changes
Feb 14, 2025
SpencerTorres
changed the title
SpencerTorres
force-pushed
the
fix_potential_overflow
branch
from
ff920c9 to
b64209f
Compare
SpencerTorres
approved these changes
Feb 14, 2025
Member
|
had to force push to fix commit lint, all good now |
SpencerTorres
changed the title
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related - https://media.defcon.org/DEF%20CON%2032/DEF%20CON%2032%20presentations/DEF%20CON%2032%20-%20Paul%20Gerste%20-%20SQL%20Injection%20Isn%27t%20Dead%20Smuggling%20Queries%20at%20the%20Protocol%20Level.pdf
It is possible to smuggle query packet into the connection when a large amount of attacker controlled data can end up in the external data of query. If Compression: CompressionNone and this overflow occurs, the remainder of the external data is processed as native protocol bytes.