perf(compressor): reduce memory by using new compression code#1040
Merged
SpencerTorres merged 1 commit intomainfrom Feb 13, 2025
Merged
perf(compressor): reduce memory by using new compression code#1040SpencerTorres merged 1 commit intomainfrom
SpencerTorres merged 1 commit intomainfrom
Conversation
SpencerTorres
force-pushed
the
compressor_etc
branch
from
71dda18 to
65a3012
Compare
ernado
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1039 included some code to reduce memory usage when initializing the compressor. After further review of ch-go and clickhouse-go, it seems only ONE compression method is ever used per connection. With this in mind I have refactored and simplified the code.
The most important line of this PR is to actually USE the optimization from #1039:
but in addition to this I have updated some functions and constants to reflect the actual usage patterns for compression.
*Writer.Compress()no longer takes aMethodsince this is known during initialization and does not change.I don't believe this is a breaking change since these packages/constants are only used internally. The compression code is abstracted by the
opt.Compressionandopt.CompressionLeveloptions.I have also re-run the benchmarks and this code is negligibly faster by ~100ns.
Let me know if I'm wrong about the usage of any of this code. Thanks!
Checklist