Skip to content

fix: expose underlying string column for json#1037

Merged
ernado merged 1 commit intomainfrom
json_string_column
Feb 1, 2025
Merged

fix: expose underlying string column for json#1037
ernado merged 1 commit intomainfrom
json_string_column

Conversation

@SpencerTorres
Copy link
Copy Markdown
Member

Summary

Small oversight from #1034, the underlying ColStr was not exported and could not be pre-allocated as needed.

proto.ColJSONStr {
	Str: proto.ColStr{
		Buf: make([]byte, 0, strSize * bufferSize),
		Pos: make([]proto.Position, 0, bufferSize),
	}
}

This PR exports Str so the above code is possible

@ernado ernado merged commit 237fd55 into main Feb 1, 2025
@ernado ernado deleted the json_string_column branch February 1, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants