Merged
Conversation
alexey-milovidov
approved these changes
Mar 12, 2021
Member
There was a problem hiding this comment.
If it builds and works - ok.
PS. Most likely it is not related to the CPU architecture but to the assembler that is being used.
These files are for GNU assembler.
Also there is a chance that this change actually breaks everything, but the related code path is disabled in runtime for Apple.
Author
@alexey-milovidov Thanks for your mention. I have updated the description. |
Merged
This was referenced Aug 16, 2023
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang on Apple m1 doesn't support
.type,.size,.section