Skip to content

Fix total mutation execution time tracking#99613

Closed
alesapin wants to merge 4 commits intomasterfrom
fix-mutation-total-milliseconds
Closed

Fix total mutation execution time tracking#99613
alesapin wants to merge 4 commits intomasterfrom
fix-mutation-total-milliseconds

Conversation

@alesapin
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Now we include commit time in total mutation execution time metric for ReplicatedMergeTree. It was lost after #96376.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 16, 2026

Workflow [PR], commit [97e05b8]

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Mar 16, 2026
@GrigoryPervakov GrigoryPervakov self-assigned this Mar 16, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 18, 2026

LLVM Coverage Report

Metric Baseline Current Δ
Lines 83.70% 83.80% +0.10%
Functions 23.90% 23.90% +0.00%
Branches 76.30% 76.30% +0.00%

PR changed lines: PR changed-lines coverage: 100.00% (50/50, 0 noise lines excluded)
Diff coverage report
Uncovered code

Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good.

@alexey-milovidov
Copy link
Copy Markdown
Member

There are no tests for this change...

@alexey-milovidov alexey-milovidov self-assigned this Mar 18, 2026
@alexey-milovidov
Copy link
Copy Markdown
Member

It will be hard to write a test.

@alexey-milovidov
Copy link
Copy Markdown
Member

@alesapin, I think it's a good one.

@alesapin
Copy link
Copy Markdown
Member Author

@alexey-milovidov agree with you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants