Skip to content

Create unique columns for literals#9950

Merged
alexey-milovidov merged 18 commits intomasterfrom
aku/literal-columns
Apr 20, 2020
Merged

Create unique columns for literals#9950
alexey-milovidov merged 18 commits intomasterfrom
aku/literal-columns

Conversation

@akuzm
Copy link
Copy Markdown
Contributor

@akuzm akuzm commented Mar 30, 2020 •
edited by 4ertus2
Loading

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix column names of constants inside JOIN that may clash with names of constants outside of JOIN.

Closes #9810

4ertus2
4ertus2 reviewed Apr 1, 2020
View reviewed changes
4ertus2
4ertus2 reviewed Apr 1, 2020
View reviewed changes
4ertus2
4ertus2 reviewed Apr 1, 2020
View reviewed changes
4ertus2
4ertus2 reviewed Apr 1, 2020
View reviewed changes
4ertus2
4ertus2 reviewed Apr 1, 2020
View reviewed changes
4ertus2
4ertus2 reviewed Apr 1, 2020
View reviewed changes
4ertus2
4ertus2 reviewed Apr 1, 2020
View reviewed changes
4ertus2
4ertus2 reviewed Apr 1, 2020
View reviewed changes
4ertus2
4ertus2 reviewed Apr 1, 2020
View reviewed changes
4ertus2
4ertus2 suggested changes Apr 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@4ertus2 4ertus2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments above

@blinkov blinkov added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 8, 2020
@alexey-milovidov alexey-milovidov removed the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 12, 2020
@blinkov blinkov added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 12, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Apr 12, 2020

I'm mostly Ok with this solution.

BTW, What will happen in query:
select cast(7 as String), * from (select number "'String'" FROM numbers(2));
?

@alexey-milovidov alexey-milovidov removed the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 12, 2020
@blinkov blinkov added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 12, 2020
@4ertus2
Copy link
Copy Markdown
Contributor

4ertus2 commented Apr 13, 2020

Another fix #10207

@alexey-milovidov alexey-milovidov added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Apr 13, 2020
@blinkov blinkov added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 13, 2020
@akuzm
Copy link
Copy Markdown
Contributor Author

akuzm commented Apr 14, 2020

I'm mostly Ok with this solution.

BTW, What will happen in query:
select cast(7 as String), * from (select number "'String'" FROM numbers(2));
?

Works as expected:

:) select cast(7 as String), * from (select number "'String'" FROM numbers(2));

┌─CAST(7, 'String')─┬─'String'─┐
│ 7                 │        0 │
│ 7                 │        1 │
└───────────────────┴──────────┘

@4ertus2 4ertus2 mentioned this pull request Apr 14, 2020
Closed
@akuzm akuzm changed the title [demo] Create unique columns for literals Create unique columns for literals Apr 14, 2020
@akuzm akuzm marked this pull request as ready for review April 14, 2020 19:59
4ertus2
4ertus2 reviewed Apr 14, 2020
View reviewed changes
4ertus2
4ertus2 reviewed Apr 14, 2020
View reviewed changes
4ertus2
4ertus2 reviewed Apr 14, 2020
View reviewed changes
@alexey-milovidov alexey-milovidov merged commit 4ecc86b into master Apr 20, 2020
@alexey-milovidov alexey-milovidov deleted the aku/literal-columns branch April 20, 2020 23:30
@alexey-milovidov alexey-milovidov mentioned this pull request May 12, 2020
Merged
@vdimir vdimir mentioned this pull request Apr 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov Awaiting requested review from alexey-milovidov

1 more reviewer

@4ertus2 4ertus2 4ertus2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@4ertus2 4ertus2

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cast bug

5 participants

@akuzm @alexey-milovidov @4ertus2 @blinkov @CurtizJ