temporary turn check for async_insert off#98831
Merged
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order not to bring noise to the CI
I temporary mute the upgrade check for setting
async_insert.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes
Note
Low Risk
Low risk: only tweaks the upgrade CI script to suppress noise from a single setting comparison, without affecting production code paths.
Overview
The upgrade CI runner no longer flags
async_insertas a changed/unknown session setting when comparingsystem.settingsbetween the previous release and the new build.This temporarily silences failures/noise from the settings-change-history check by excluding
async_insertfrom the diff written tochanged_settings.txt.Written by Cursor Bugbot for commit c3aff3c. This will update automatically on new commits. Configure here.