Skip to content

Revert "Revert "turn on async insert""#98825

Merged
CheSema merged 2 commits intomasterfrom
revert-98800-revert-97590-chesema-async-insert-on
Mar 6, 2026
Merged

Revert "Revert "turn on async insert""#98825
CheSema merged 2 commits intomasterfrom
revert-98800-revert-97590-chesema-async-insert-on

Conversation

@CheSema
Copy link
Copy Markdown
Member

@CheSema CheSema commented Mar 5, 2026

Reverts #98800


Note

Medium Risk
Changes the default async_insert behavior to enabled, which can alter INSERT latency/flush semantics and surface edge cases in clients and tests. Remaining code changes are mostly logging and test/config adjustments to force synchronous inserts where needed.

Overview
Enables async_insert by default by flipping the default in Settings and recording the behavior change in SettingsChangesHistory (26.2), with updated settings baseline expectations.

Updates AsynchronousInsertQueue to use the newer InterpreterInsertQuery::getSampleBlock signature and improves async-insert diagnostics by logging the batch’s source query_ids (and reducing reliance on the full query string) for queueing, flushing, and parse errors.

Adjusts test infrastructure/configuration to explicitly disable async inserts in many integration/stateless tests (new disable_async_inserts.xml, install script wiring, and per-test user configs) to keep tests deterministic under the new default.

Written by Cursor Bugbot for commit 9dac366. This will update automatically on new commits. Configure here.

@CheSema CheSema mentioned this pull request Mar 5, 2026
1 task
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 5, 2026

Workflow [PR], commit [9dac366]

Summary:

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, WasmEdge, sequential) failure
00991_system_parts_race_condition_long FAIL cidb
Unknown error FAIL cidb

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 5, 2026
@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Mar 5, 2026

That PR
turn on async insert
#97590
has been reverted due to broken upgrade check

https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=98798&sha=cf5604bd60ed4019046f8a5f7a435f9e4025d933&name_0=PR&name_1=Upgrade%20check%20%28amd_release%29&name_1=Upgrade%20check%20%28amd_release%29

The reason is that upgrade check took 26.2.3.2 and there is async_insert=0
When in master, it is async_insert=1 .
But this PR 97590 is suppose to be bacported, it changes the history as if this async_insert setting is changed in 26.2. And it has been backported and is available since 26.2.4.17 in public.

All we need to do is wait until the upgrade check pulls a fresher build.

@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Mar 5, 2026

That PR
#98831
helps not to pollute the CI with errors until I merge this PR

@CheSema CheSema added this pull request to the merge queue Mar 5, 2026
Merged via the queue into master with commit 11fbb78 Mar 6, 2026
148 of 150 checks passed
@CheSema CheSema deleted the revert-98800-revert-97590-chesema-async-insert-on branch March 6, 2026 00:13
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 6, 2026
@vitlibar vitlibar mentioned this pull request Mar 7, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants