Revert "Revert "turn on async insert""#98825
Merged
Conversation
Contributor
|
Workflow [PR], commit [9dac366] Summary: ❌
|
Member
Author
|
That PR The reason is that upgrade check took 26.2.3.2 and there is async_insert=0 All we need to do is wait until the upgrade check pulls a fresher build. |
Member
Author
|
That PR |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #98800
Note
Medium Risk
Changes the default
async_insertbehavior to enabled, which can alter INSERT latency/flush semantics and surface edge cases in clients and tests. Remaining code changes are mostly logging and test/config adjustments to force synchronous inserts where needed.Overview
Enables
async_insertby default by flipping the default inSettingsand recording the behavior change inSettingsChangesHistory(26.2), with updated settings baseline expectations.Updates
AsynchronousInsertQueueto use the newerInterpreterInsertQuery::getSampleBlocksignature and improves async-insert diagnostics by logging the batch’s source query_ids (and reducing reliance on the full query string) for queueing, flushing, and parse errors.Adjusts test infrastructure/configuration to explicitly disable async inserts in many integration/stateless tests (new
disable_async_inserts.xml, install script wiring, and per-test user configs) to keep tests deterministic under the new default.Written by Cursor Bugbot for commit 9dac366. This will update automatically on new commits. Configure here.