Skip to content

Fix 01455_opentelemetry_distributed flaky test by adding few retries#98552

Merged
alexbakharew merged 1 commit intomasterfrom
abakharew/fix-race-in-http-handler
Mar 5, 2026
Merged

Fix 01455_opentelemetry_distributed flaky test by adding few retries#98552
alexbakharew merged 1 commit intomasterfrom
abakharew/fix-race-in-http-handler

Conversation

@alexbakharew
Copy link
Copy Markdown
Contributor

@alexbakharew alexbakharew commented Mar 2, 2026

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

This probably fixes #67108 and #93452


Note

Low Risk
Low risk: only adjusts a shell-based integration test to tolerate delayed span logging; no production code changes.

Overview
Reduces flakiness in 01455_opentelemetry_distributed.sh by adding a short retry loop that repeatedly flushes opentelemetry_span_log and waits until the expected gateway span appears before running assertions.

Removes the one-off system flush logs call inside the main query block since spans are now flushed during the retry.

Written by Cursor Bugbot for commit 622f9bb. This will update automatically on new commits. Configure here.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 2, 2026

Workflow [PR], commit [622f9bb]

Summary:

@clickhouse-gh clickhouse-gh bot added the pr-ci label Mar 2, 2026
@alexbakharew alexbakharew force-pushed the abakharew/fix-race-in-http-handler branch from f295933 to 622f9bb Compare March 5, 2026 09:34
@alexbakharew alexbakharew changed the title Destroy trace_context earlier to write spans before query ends Fix 01455_opentelemetry_distributed flaky test by adding few retries Mar 5, 2026
@alexbakharew alexbakharew marked this pull request as ready for review March 5, 2026 09:36
@alexbakharew alexbakharew requested a review from mstetsyuk March 5, 2026 09:36
@alexbakharew alexbakharew added this pull request to the merge queue Mar 5, 2026
Merged via the queue into master with commit 7293eb0 Mar 5, 2026
150 checks passed
@alexbakharew alexbakharew deleted the abakharew/fix-race-in-http-handler branch March 5, 2026 12:58
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stateless test 01455_opentelemetry_distributed is flaky

3 participants