Fix JOIN rewriters inconsistency#9830
Merged
4ertus2 merged 3 commits intoClickHouse:masterfrom Mar 23, 2020
Merged
Conversation
4ertus2
commented
Mar 23, 2020
| throw Exception("Multiple CROSS/COMMA JOIN do not support USING", ErrorCodes::NOT_IMPLEMENTED); | ||
|
|
||
| if (num_comma && (num_comma != (joined_tables.size() - 1))) | ||
| throw Exception("Mix of COMMA and other JOINS is not supported", ErrorCodes::NOT_IMPLEMENTED); |
Contributor
Author
There was a problem hiding this comment.
It also removes mix COMMA + other JOIN restriction (for TPC-DS support).
Contributor
Author
There was a problem hiding this comment.
FYI @alex-zaitsev
Fix for 2 cases in TPC-DS list.
There're same 'Missing columns' and 'exists/not exists' issues in TPC-H test too.
4ertus2
added a commit
that referenced
this pull request
Mar 26, 2020
* fix join rewrites: inconsistent visitors
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix 'COMMA to CROSS JOIN rewriter is not enabled or cannot rewrite query' error in case of subqueries with COMMA JOIN out of tables lists (i.e. in WHERE). Fixes #9782
Detailed description / Documentation draft:
Make JoinToSubqueryTransformVisitor consistent with CrossToInnerJoinVisitor: do not go into subqueries.