Fix flaky test 01079_parallel_alter_detach_table_zookeeper#97681
Merged
alexey-milovidov merged 2 commits intomasterfrom Feb 23, 2026
Merged
Fix flaky test 01079_parallel_alter_detach_table_zookeeper#97681alexey-milovidov merged 2 commits intomasterfrom
01079_parallel_alter_detach_table_zookeeper#97681alexey-milovidov merged 2 commits intomasterfrom
Conversation
In `DatabaseReplicated` mode, `DROP TABLE IF EXISTS` can produce a
`TIMEOUT_EXCEEDED` error, which `clickhouse-client` outputs as a
multi-line message to stderr:
Received exception from server (version ...):
Code: 159. DB::Exception: ... TIMEOUT_EXCEEDED
(query: DROP TABLE IF EXISTS ...)
The test redirects stderr to stdout (`2>&1`) and filters with
`grep -Fv "TIMEOUT_EXCEEDED"`, but this only removes the middle line.
The surrounding lines (`Received exception...` and `(query: ...)`)
pass through to stdout and cause a diff with the reference file.
Fix by joining lines with `tr '\n' ' '` before `grep`, so the entire
error is on one line and gets filtered properly.
https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=97670&sha=8ca4b2d3d5c5c952378bcb73aec55e7d76f120e3&name_0=PR&name_1=Stateless%20tests%20%28amd_binary%2C%20old%20analyzer%2C%20s3%20storage%2C%20DatabaseReplicated%2C%20sequential%29
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
…allel-alter-detach-2
Algunenano
pushed a commit
to Algunenano/ClickHouse
that referenced
this pull request
Feb 24, 2026
…arallel-alter-detach-2 Fix flaky test `01079_parallel_alter_detach_table_zookeeper`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97358
CI report: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=97670&sha=8ca4b2d3d5c5c952378bcb73aec55e7d76f120e3&name_0=PR&name_1=Stateless%20tests%20%28amd_binary%2C%20old%20analyzer%2C%20s3%20storage%2C%20DatabaseReplicated%2C%20sequential%29
In
DatabaseReplicatedmode,DROP TABLE IF EXISTScleanup commands can get aTIMEOUT_EXCEEDEDerror, whichclickhouse-clientoutputs as a multi-line message. The existinggrep -Fv "TIMEOUT_EXCEEDED"only filtered the middle line, lettingReceived exception from serverand(query: ...)lines leak into stdout. Fix by joining lines withtr '\n' ' 'beforegrepso the whole error is on one line and gets filtered.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes