Fix flaky test 01111_create_drop_replicated_db_stress#97592
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 22, 2026
Merged
Fix flaky test 01111_create_drop_replicated_db_stress#97592alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
The `DDLGuard` constructor has a hard-coded 1000 ms timeout for acquiring a shared database lock. When `DROP DATABASE` holds the exclusive lock longer than 1 second (e.g. due to ZooKeeper cleanup on a loaded CI machine), table-level DDL operations (`CREATE TABLE`, `ALTER TABLE`) fail with `TIMEOUT_EXCEEDED`. The `sync_db` function already filtered this exception, but `create_table` and `alter_table` did not. Add `TIMEOUT_EXCEEDED` filtering to both, since this timeout is expected under concurrent create/drop stress. #97539 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
alexey-milovidov
deleted the
fix-01111-create-drop-replicated-db-stress-flaky
branch
robot-ch-test-poll4
added
the
pr-synced-to-cloud
Algunenano
pushed a commit
to Algunenano/ClickHouse
that referenced
this pull request
Feb 24, 2026
…drop-replicated-db-stress-flaky Fix flaky test 01111_create_drop_replicated_db_stress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TIMEOUT_EXCEEDEDexceptions increate_tableandalter_tablefunctions in the stress testDDLGuardhas a hard-coded 1000 ms timeout for acquiring a shared database lock, which is insufficient whenDROP DATABASEholds the exclusive lock longer under CI loadsync_dbfunction already filtered this exception; nowcreate_tableandalter_tabledo tooFixes #97539
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes
🤖 Generated with Claude Code