Rewrite multiple JOINs v2#9739
Merged
alexey-milovidov merged 11 commits intoClickHouse:masterfrom Mar 22, 2020
Merged
Conversation
Contributor
Author
|
For now V2 works but leads to regression in #6767 I think it would be OK to merge with disabled setting after tests pass. |
Member
|
@zhang2014 We are struggle to find why we have a regression in #6767 |
Contributor
|
I'll try to fix it, but may take one or two weeks(after done ClickHouse WebTerminal :) ). It seems that the 'JOIN Key ' is not handled correctly |
This was referenced Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
If
set multiple_joins_rewriter_version = 2enables second version of multiple JOIN rewrites that keeps not clashed column names as is. It supports multiple JOINs withUSINGand allowselect *for JOINs with subqueries.Detailed description / Documentation draft: