Fix flaky 00365_statistics_in_formats with parallel replicas#96970
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 15, 2026
Merged
Fix flaky 00365_statistics_in_formats with parallel replicas#96970alexey-milovidov merged 1 commit intomasterfrom
00365_statistics_in_formats with parallel replicas#96970alexey-milovidov merged 1 commit intomasterfrom
Conversation
The test checks `rows_read` statistics in JSON/JSONCompact/XML output formats. With parallel replicas, there is a race condition where the output format's `finalizeImpl` writes the statistics footer before all progress from connection draining has been reported, resulting in `rows_read` being 0 instead of 10. Closes #85785 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Member
Author
|
We should investigate the root cause: why format statistics are not received correctly with parallel replicas? Can we fix that? |
Contributor
Member
Author
|
This is a suppression of a real, but unimportant problem. The root cause fix is here: #96978 |
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test checks
rows_readstatistics in JSON/JSONCompact/XML output formats. With parallel replicas, there is a race condition where the output format'sfinalizeImplwrites the statistics footer before all progress from connection draining has been reported, resulting inrows_readbeing 0 instead of 10.Add the
no-parallel-replicastag to avoid the flakiness.Closes #85785
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes