Fix flaky test 01062_pm_all_join_with_block_continuation#96967
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 15, 2026
Merged
Conversation
Reduce data sizes by 10x (from 10M to 1M result rows per query) and proportionally reduce `max_memory_usage` from 50MB to 12MB so the `MEMORY_LIMIT_EXCEEDED` test cases still trigger. This makes the test fast enough to remove the `no-asan` and `long` tags. Closes #86334 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
alexey-milovidov
deleted the
fix-flaky-01062-pm-all-join-with-block-continuation
branch
Member
Author
|
Does the test still exercise the block continuation path? The coverage comparison could come handy, CC @alexbakharew |
robot-ch-test-poll4
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_memory_usagefrom 50MB to 12MB so theMEMORY_LIMIT_EXCEEDEDtest cases still triggerno-asanandlongtags since the test now completes in under 1 secondpartial_mergejoin with block continuation, memory limits,max_joined_block_size_rows, andmax_rows_in_joinsettingsCloses #86334
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes
🤖 Generated with Claude Code