Maybe fix flaky test_fix_metadata_version_on_attach_part_after_restore#96499
Merged
alexey-milovidov merged 2 commits intomasterfrom Feb 10, 2026
Merged
Conversation
Move `test_fix_metadata_version_on_attach_part_after_restore` from `test_restore_replica` to its own test module `test_restore_replica_metadata_version`. The test shared a module-scoped cluster with 4 other tests that perform 10+ `SYSTEM RESTART REPLICA` operations. Each restart destroys and recreates storage objects with background threads. In TSAN builds, the accumulated thread churn can exhaust TSAN internal thread slot tracking, causing a segfault in `__tsan::TraceMutexUnlock` during a system table background merge — crashing the server and failing this unrelated test. The test is fully independent: it creates its own `test_ttl` table on only 2 nodes and shares no state with the other restore replica tests. Giving it a fresh cluster avoids the accumulated TSAN thread debris. https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=96437&sha=de1caa72d9160d3d01d29245a6f7f1ba453a46e1&name_0=PR&name_1=Integration%20tests%20%28amd_tsan%2C%206%2F6%29 Closes #88500 Co-Authored-By: Claude Opus 4.6 <[email protected]>
alexey-milovidov
changed the title
test_fix_metadata_version_on_attach_part_after_restoretest_fix_metadata_version_on_attach_part_after_restore
Contributor
alexey-milovidov
deleted the
fix-flaky-test-restore-replica-metadata-version
branch
robot-ch-test-poll3
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
test_fix_metadata_version_on_attach_part_after_restorefromtest_restore_replicato its own test moduletest_restore_replica_metadata_version.The test shared a module-scoped cluster with 4 other tests that perform 10+
SYSTEM RESTART REPLICAoperations. Each restart destroys and recreates storage objects with background threads. In TSAN builds, the accumulated thread churn can exhaust TSAN internal thread slot tracking, causing a segfault in__tsan::TraceMutexUnlockduring a system table background merge — crashing the server and failing this unrelated test.The test is fully independent: it creates its own
test_ttltable on only 2 nodes and shares no state with the other restore replica tests. Giving it a fresh cluster avoids the accumulated TSAN thread debris.https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=96437&sha=de1caa72d9160d3d01d29245a6f7f1ba453a46e1&name_0=PR&name_1=Integration%20tests%20%28amd_tsan%2C%206%2F6%29
Closes #88500
Changelog category (leave one):