Skip to content

Fix test_restore_db_replica: Wait for async recovery after SYSTEM RESTORE DATABASE REPLICA#96302

Merged
alexey-milovidov merged 1 commit intomasterfrom
fix-restore-db-replica-flaky
Feb 8, 2026
Merged

Fix test_restore_db_replica: Wait for async recovery after SYSTEM RESTORE DATABASE REPLICA#96302
alexey-milovidov merged 1 commit intomasterfrom
fix-restore-db-replica-flaky

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

SYSTEM RESTORE DATABASE REPLICA returns before the DDL worker finishes the actual recovery (table recreation from ZK metadata). Without waiting, subsequent operations on restored tables can fail with "Table does not exist" or miss tables in system.tables queries.

Add wait_for_log_line("All tables are created successfully") after each restore call, matching the pattern already used in other tests in the same file.

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

`SYSTEM RESTORE DATABASE REPLICA` returns before the DDL worker
finishes the actual recovery (table recreation from ZK metadata).
Without waiting, subsequent operations on restored tables can fail
with "Table does not exist" or miss tables in system.tables queries.

Add `wait_for_log_line("All tables are created successfully")` after
each restore call, matching the pattern already used in other tests
in the same file.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 7, 2026

Workflow [PR], commit [89431dd]

Summary:

job_name test_name status info comment
Integration tests (amd_binary, 1/5) error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

post-approved Approved, but after the PR is merged. pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants