Support convert OUTER to INNER join optimization with join_use_nulls#95968
Merged
Support convert OUTER to INNER join optimization with join_use_nulls#95968
Conversation
Contributor
|
Workflow [PR], commit [7e85b38] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-improvement
vdimir
force-pushed
the
vdimir/join_use_nulls_outer_to_inner
branch
2 times, most recently
from
4732a02 to
6f87c03
Compare
novikd
reviewed
Feb 11, 2026
| continue; | ||
|
|
||
| /// Skip if type is changed. Push down expression expect equal types. | ||
| if (!input_header->getByName(name).type->equals(*join_header->getByName(name).type)) |
Member
Author
There was a problem hiding this comment.
Should work fine, for storage join we cannot apply outer to inner conversion. Added test case with join_use_nulls to 03573_join_storage_not_change_kind.sql.
This reverts commit 24d42e6.
vdimir
force-pushed
the
vdimir/join_use_nulls_outer_to_inner
branch
from
a5510de to
5d4854f
Compare
novikd
approved these changes
Feb 24, 2026
robot-ch-test-poll4
added
the
pr-synced-to-cloud
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
join_use_nulls = 1#90978