Skip to content

Fix invalid result of joining two -Cluster table functions#94748

Merged
thevar1able merged 5 commits intomasterfrom
try-fix-cluster-table-function-join
Jan 26, 2026
Merged

Fix invalid result of joining two -Cluster table functions#94748
thevar1able merged 5 commits intomasterfrom
try-fix-cluster-table-function-join

Conversation

@thevar1able
Copy link
Copy Markdown
Member

@thevar1able thevar1able commented Jan 21, 2026

Assisted-by: Claude Sonnet 4.5 via GitHub Copilot

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix invalid result on joining multiple table expressions, when leftmost table expression is a -Cluster table function. Resolves #89996

@thevar1able thevar1able changed the title Try wrapping left storage in a subquery automatically Fix invalid result on joining two -Cluster table functions Jan 21, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 21, 2026

Workflow [PR], commit [4a08b50]

Summary:

job_name test_name status info comment
Integration tests (amd_tsan, 4/6) failure
test_backup_restore_s3/test.py::test_backup_restore_system_tables_with_plain_rewritable_disk[data_file_name_from_first_file_name] FAIL cidb, issue ISSUE EXISTS
Performance Comparison (amd_release, master_head, 1/6) failure
Check Results failure IGNORED

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jan 21, 2026
Assisted-by: Claude Sonnet 4.5 via GitHub Copilot
@thevar1able thevar1able force-pushed the try-fix-cluster-table-function-join branch from 0862f28 to 5b364db Compare January 21, 2026 20:20
@thevar1able thevar1able changed the title Fix invalid result on joining two -Cluster table functions Fix invalid result of joining two -Cluster table functions Jan 21, 2026
@novikd novikd self-assigned this Jan 22, 2026
Assisted-by: Claude Sonnet 4.5 via GitHub Copilot
@thevar1able thevar1able marked this pull request as ready for review January 23, 2026 15:38
Assisted-by: Claude Sonnet 4.5 via GitHub Copilot
@thevar1able thevar1able marked this pull request as draft January 26, 2026 16:30
@thevar1able thevar1able marked this pull request as ready for review January 26, 2026 16:58
@thevar1able thevar1able added this pull request to the merge queue Jan 26, 2026
Merged via the queue into master with commit 2b769e0 Jan 26, 2026
131 of 134 checks passed
@thevar1able thevar1able deleted the try-fix-cluster-table-function-join branch January 26, 2026 20:41
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FULL OUTER JOIN works incorrectly with Cluster functions

4 participants