Skip to content

cleaning duplicate linker flags#9433

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
amosbird:cleanbuild
Feb 28, 2020
Merged

cleaning duplicate linker flags#9433
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
amosbird:cleanbuild

Conversation

@amosbird
Copy link
Copy Markdown
Collaborator

@amosbird amosbird commented Feb 28, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Clean up duplicated linker flags. Make sure the linker won't look up an unexpected symbol.

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Feb 28, 2020

For the reference: before this change, the linker command contained duplicate -lpthread in the middle of the list of libraries and we get dependency on C11 threads (symbols like cnd_broadcast) if we build with glibc 2.28+.

@alexey-milovidov alexey-milovidov added pr-build Pull request with build/testing/packaging improvement no-docs-needed labels Feb 28, 2020
@amosbird
Copy link
Copy Markdown
Collaborator Author

symbols like cnd_broadcast

which gets picked up by librdkafka

@alexey-milovidov
Copy link
Copy Markdown
Member

which gets picked up by librdkafka

  • rdkafka is build without flag that enables C11 threads;
  • it implements its own methods for C11 threads with identical names;
  • but if -lpthread is before -lrdkafka, linker is leaving the dependency on C11 symbols from pthread (?)

@alexey-milovidov
Copy link
Copy Markdown
Member

Performance test Ok.

@alexey-milovidov alexey-milovidov merged commit a9a757d into ClickHouse:master Feb 28, 2020
alesapin pushed a commit that referenced this pull request Mar 27, 2020
cleaning duplicate linker flags

(cherry picked from commit a9a757d)
KochetovNicolai pushed a commit that referenced this pull request Apr 2, 2020
cleaning duplicate linker flags

(cherry picked from commit a9a757d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-docs-needed pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants