Skip to content

Slightly optimize squashing of JSON columns for some cases#94247

Merged
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:better-squash
Jan 19, 2026
Merged

Slightly optimize squashing of JSON columns for some cases#94247
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:better-squash

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Jan 14, 2026

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Slightly optimize squashing of JSON columns for some cases

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 14, 2026

Workflow [PR], commit [7cfa702]

Summary:

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Jan 14, 2026
@Algunenano Algunenano self-assigned this Jan 15, 2026
@Algunenano Algunenano requested a review from Copilot January 15, 2026 10:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the insertion operations for JSON columns by adding fast-path optimizations when the limit on dynamic paths has been reached and the set of dynamic paths matches between source and destination columns.

Changes:

  • Added optimization in doInsertFrom to directly insert from source shared data when dynamic path sets match
  • Added optimization in doInsertRangeFrom to directly insert range from source shared data when dynamic path sets match

@Avogar Avogar added this pull request to the merge queue Jan 19, 2026
Merged via the queue into ClickHouse:master with commit 7015e01 Jan 19, 2026
132 checks passed
@Avogar Avogar deleted the better-squash branch January 19, 2026 11:33
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 19, 2026
@Avogar Avogar mentioned this pull request Mar 6, 2026
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants