Skip to content

Fix rebuilding of projections with _part_offset during merge#93827

Merged
KochetovNicolai merged 3 commits intoClickHouse:masterfrom
amosbird:cond-93233
Jan 13, 2026
Merged

Fix rebuilding of projections with _part_offset during merge#93827
KochetovNicolai merged 3 commits intoClickHouse:masterfrom
amosbird:cond-93233

Conversation

@amosbird
Copy link
Copy Markdown
Collaborator

@amosbird amosbird commented Jan 9, 2026 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixed _part_offset corruption when projections are rebuilt during merges, and optimized projection processing by avoiding unnecessary reads of the _part_offset column and skipping unneeded columns in projection calculations. This continues the optimizations introduced in #93233.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 9, 2026 •
edited by KochetovNicolai
Loading

Workflow [PR], commit [4aa8cb2]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_asan, distributed plan, parallel, 2/2) failure
03702_alter_column_update_and_delete_with_secondary_index_drop FAIL cidb, issue ISSUE EXISTS
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, sequential) failure
01154_move_partition_long FAIL cidb, issue ISSUE EXISTS
Stateless tests (amd_debug, distributed plan, s3 storage, sequential) failure
02350_views_max_insert_threads FAIL cidb, issue ISSUE EXISTS
Stateless tests (arm_binary, parallel) failure
02346_text_index_materialization FAIL cidb, issue ISSUE EXISTS
Scrapping system tables FAIL cidb, issue ISSUE EXISTS
AST fuzzer (amd_ubsan) failure
UndefinedBehaviorSanitizer: undefined behavior (STID: 3262-4864) FAIL cidb IGNORED
Integration tests (amd_asan, targeted) error IGNORED

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 9, 2026
@amosbird amosbird changed the title Proper handle _part_offset column during merge/mutation of projections Fix rebuilding of projections with _part_offset during merge Jan 10, 2026
@amosbird amosbird added pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! v25.8-must-backport and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Jan 10, 2026
@KochetovNicolai KochetovNicolai added this pull request to the merge queue Jan 13, 2026
@KochetovNicolai
Copy link
Copy Markdown
Member

KochetovNicolai commented Jan 13, 2026

UB: #90979

Merged via the queue into ClickHouse:master with commit 3e97426 Jan 13, 2026
125 of 132 checks passed
This was referenced Jan 13, 2026
Closed
Merged
Closed
Closed
Closed
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 13, 2026
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jan 13, 2026
robot-ch-test-poll added a commit that referenced this pull request Jan 29, 2026
@robot-ch-test-poll
Merge pull request #94041 from ClickHouse/cherrypick/25.8/93827
3e89633 
Cherry pick #93827 to 25.8: Fix rebuilding of projections with _part_offset during merge
robot-clickhouse added a commit that referenced this pull request Jan 29, 2026
@robot-clickhouse
Backport #93827 to 25.8: Fix rebuilding of projections with _part_off…
69607cd 
…set during merge
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Jan 29, 2026
Merged
amosbird pushed a commit to amosbird/ClickHouse that referenced this pull request Jan 29, 2026
@KochetovNicolai @amosbird
Merge pull request ClickHouse#93827 from amosbird/cond-93233
edbfced 
Fix rebuilding of projections with _part_offset during merge
@amosbird amosbird mentioned this pull request Jan 30, 2026
Merged
KochetovNicolai added a commit that referenced this pull request Jan 30, 2026
@KochetovNicolai
Merge pull request #95588 from amosbird/cherrypick/25.8/93827
9dd9b68 
Backport #93827 to 25.8: Fix rebuilding of projections with _part_offset during merge
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Jan 31, 2026
Closed
amosbird pushed a commit to amosbird/ClickHouse that referenced this pull request Feb 3, 2026
@KochetovNicolai @amosbird
Backport ClickHouse#93827 to 25.11: Fix rebuilding of projections wit…
b73ad8f 
…h _part_offset during merge
@amosbird amosbird mentioned this pull request Feb 3, 2026
Merged
amosbird pushed a commit to amosbird/ClickHouse that referenced this pull request Feb 3, 2026
@KochetovNicolai @amosbird
Merge pull request ClickHouse#93827 from amosbird/cond-93233
4482149 
Fix rebuilding of projections with _part_offset during merge
This was referenced Feb 3, 2026
Closed
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 3, 2026
amosbird pushed a commit to amosbird/ClickHouse that referenced this pull request Feb 3, 2026
@KochetovNicolai @amosbird
Merge pull request ClickHouse#93827 from amosbird/cond-93233
fbfc786 
Fix rebuilding of projections with _part_offset during merge
amosbird pushed a commit to amosbird/ClickHouse that referenced this pull request Feb 3, 2026
@KochetovNicolai @amosbird
Backport ClickHouse#93827 to 25.11: Fix rebuilding of projections wit…
6364315 
…h _part_offset during merge
clickhouse-gh bot added a commit that referenced this pull request Feb 3, 2026
@clickhouse-gh
Merge pull request #95871 from amosbird/backport-93827-to-25.11
8791b8a 
Backport #93827 to 25.11: Fix rebuilding of projections with _part_offset during merge
KochetovNicolai added a commit that referenced this pull request Feb 3, 2026
@KochetovNicolai
Merge pull request #95873 from amosbird/backport-93827-to-25.12-2
a7a34a3 
Backport #93827 to 25.12: Fix rebuilding of projections with _part_offset during merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.8-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amosbird @KochetovNicolai @robot-clickhouse @robot-ch-test-poll @robot-ch-test-poll4