Fix bad test 03238_create_or_replace_view_atomically_with_replicated_engine.sh#93664
Merged
alexey-milovidov merged 4 commits intomasterfrom Jan 9, 2026
Merged
Fix bad test 03238_create_or_replace_view_atomically_with_replicated_engine.sh#93664alexey-milovidov merged 4 commits intomasterfrom
03238_create_or_replace_view_atomically_with_replicated_engine.sh#93664alexey-milovidov merged 4 commits intomasterfrom
Conversation
alexey-milovidov
changed the title
03238_create_or_replace_view_atomically_with_replicated_engine.sh
Contributor
Member
|
cc @tuanpach I only appear as author because I reverted the original PR because of the bad tests and open a revert of revert so it was fixed (and it wasn't) |
…_atomically_with_replicated_engine.sh with curl, similarly to other tests
Member
Author
|
Ok. It looks like OOM due to too many concurrent invocations of clickhouse-client, while under sanitizers, it takes a lot of RAM. |
Member
|
Thanks for tidying the test. |
robot-ch-test-poll2
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
For some reason, the test used
export -fandbash. Closes #92917.It's so annoying:
https://play.clickhouse.com/play?user=play&run=1#V0lUSAogICAgOTAgQVMgaW50ZXJ2YWxfZGF5cwpTRUxFQ1QKICAgIHRvU3RhcnRPZkRheShjaGVja19zdGFydF90aW1lKSBBUyBkYXksCiAgICBjb3VudCgpIEFTIGZhaWx1cmVzLAogICAgZ3JvdXBVbmlxQXJyYXkocHVsbF9yZXF1ZXN0X251bWJlcikgQVMgcHJzLAogICAgYW55KHJlcG9ydF91cmwpIEFTIHJlcG9ydF91cmwKRlJPTSBjaGVja3MKV0hFUkUgKG5vdygpIC0gdG9JbnRlcnZhbERheShpbnRlcnZhbF9kYXlzKSkgPD0gY2hlY2tfc3RhcnRfdGltZQogICAgQU5EIHRlc3RfbmFtZSA9ICcwMzIzOF9jcmVhdGVfb3JfcmVwbGFjZV92aWV3X2F0b21pY2FsbHlfd2l0aF9yZXBsaWNhdGVkX2VuZ2luZScKICAgIC0tIEFORCBjaGVja19uYW1lID0gJ1N0YXRlbGVzcyB0ZXN0cyAoYW1kX2FzYW4sIGRpc3RyaWJ1dGVkIHBsYW4sIHBhcmFsbGVsLCAxLzIpJwogICAgQU5EIHRlc3Rfc3RhdHVzIElOICgnRkFJTCcsICdFUlJPUicpCiAgICBBTkQgKChwdWxsX3JlcXVlc3RfbnVtYmVyID0gMCBBTkQgaGVhZF9yZWYgPSAnZml4LXN0eWxlLXRva2VuLWV4dHJhY3RvcicpIE9SIChwdWxsX3JlcXVlc3RfbnVtYmVyICE9IDAgQU5EIGJhc2VfcmVmID0gJ21hc3RlcicpKQpHUk9VUCBCWSBkYXkKT1JERVIgQlkgZGF5IERFU0MK
CC @Algunenano