Slightly optimize parsing of JSON type#93614
Merged
Avogar merged 10 commits intoClickHouse:masterfrom Jan 29, 2026
Merged
Conversation
Contributor
|
Workflow [PR], commit [4773f84] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-performance
Member
Author
|
Avogar
commented
Jan 14, 2026
Comment on lines
-113
to
-115
| ColumnCheckpoints checkpoints(columns.size()); | ||
| for (size_t column_idx = 0; column_idx < columns.size(); ++column_idx) | ||
| checkpoints[column_idx] = columns[column_idx]->getCheckpoint(); |
Member
Author
There was a problem hiding this comment.
Creating and updating checkpoints slows down parsing in general. It's quite noticable in the flamegraph when there are thousands of subcolumns inside the type when we create and update a checkpoint for each of the subcolumn.
In general, all input formats should handle errors gracefully and don't leave inconsistent columns. In this PR I added fixes for known places where we didn't do it
antonio2368
reviewed
Jan 20, 2026
antonio2368
approved these changes
Jan 21, 2026
…ze-insert-into-json
…ze-insert-into-json
Merged
via the queue into
ClickHouse:master
with commit Jan 29, 2026
7ea6f88
129 of 134 checks passed
robot-ch-test-poll2
added
the
pr-synced-to-cloud
56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Slightly optimize parsing of JSON type.
Documentation entry for user-facing changes