Skip to content

Fix flaky test in test_merge_tree_s3 and others with retry_attempts=0#93564

Merged
CheSema merged 4 commits intomasterfrom
Fix_test_merge_tree_s3
Jan 12, 2026
Merged

Fix flaky test in test_merge_tree_s3 and others with retry_attempts=0#93564
CheSema merged 4 commits intomasterfrom
Fix_test_merge_tree_s3

Conversation

@SmitaRKulkarni
Copy link
Copy Markdown
Member

@SmitaRKulkarni SmitaRKulkarni commented Jan 7, 2026 •
edited
Loading

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

resolves #92909

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@SmitaRKulkarni SmitaRKulkarni requested a review from CheSema January 7, 2026 10:19
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 7, 2026 •
edited
Loading

Workflow [PR], commit [f88fea5]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_tsan, 3/6) failure
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_backups_on_same_node FAIL cidb, issue
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_backups_on_different_nodes FAIL cidb
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_restores_on_same_node FAIL cidb
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_restores_on_different_node FAIL cidb, issue
Integration tests (amd_asan, targeted) error

@clickhouse-gh clickhouse-gh bot added the pr-ci label Jan 7, 2026
CheSema
CheSema reviewed Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@CheSema CheSema left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that this would fix flakiness.

It flaks due to

<retry_attempts>0</retry_attempts>

in the storages broken_s3, broken_s3_always_multi_part and s3 function broken_s3.

Even without fault ejection any queries to such storages could emit errors.
I think it is impossible to have a reliable test with retry_attempts=0 in our CI. That tests have to be rewritten completely.

@CheSema CheSema self-assigned this Jan 8, 2026
@CheSema
Copy link
Copy Markdown
Member

CheSema commented Jan 8, 2026 •
edited
Loading

I will add here few changes.

@CheSema CheSema changed the title Fix flaky test in test_merge_tree_s3 Fix flaky test in test_merge_tree_s3 and others with retry_attempts=0 Jan 8, 2026
@SmitaRKulkarni SmitaRKulkarni self-assigned this Jan 9, 2026
SmitaRKulkarni
SmitaRKulkarni commented Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member Author

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SmitaRKulkarni
Copy link
Copy Markdown
Member Author

SmitaRKulkarni commented Jan 9, 2026

@CheSema : As author of PR, I am not able to approve it. Please approve and merge

@CheSema CheSema added this pull request to the merge queue Jan 12, 2026
Merged via the queue into master with commit 3a0a85f Jan 12, 2026
130 of 133 checks passed
@CheSema CheSema deleted the Fix_test_merge_tree_s3 branch January 12, 2026 14:58
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CheSema CheSema CheSema approved these changes

Assignees

@SmitaRKulkarni SmitaRKulkarni

@CheSema CheSema

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: test_merge_tree_s3/test.py::test_merge_canceled_by_s3_errors[node-broken_s3]

3 participants

@SmitaRKulkarni @CheSema @robot-clickhouse