Fix interpolate: disambiguate interpolated columns with __interpolate function#93197
Merged
KochetovNicolai merged 3 commits intomasterfrom Jan 2, 2026
Merged
Fix interpolate: disambiguate interpolated columns with __interpolate function#93197KochetovNicolai merged 3 commits intomasterfrom
KochetovNicolai merged 3 commits intomasterfrom
Conversation
Contributor
|
Workflow [PR], commit [51e1600] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-bugfix
…'s an exclusively internal function
robot-ch-test-poll4
added
the
pr-synced-to-cloud
1 task
maxjustus
added a commit
to maxjustus/ClickHouse
that referenced
this pull request
Jan 29, 2026
The `__interpolate` function was added in PR ClickHouse#93197 and subsequently reverted. This branch had code wrapping INTERPOLATE columns in `__interpolate` function calls, but the function implementation no longer exists after rebase. Changes: - Remove `interpolate_list` parameter from `resolveProjectionExpressionNodeList` - Remove `__interpolate` wrapping logic from projection resolution - Remove construction of `interpolate_list` set in `resolveQuery`
maxjustus
added a commit
to maxjustus/ClickHouse
that referenced
this pull request
Mar 21, 2026
The `__interpolate` function was added in PR ClickHouse#93197 and subsequently reverted. This branch had code wrapping INTERPOLATE columns in `__interpolate` function calls, but the function implementation no longer exists after rebase. Changes: - Remove `interpolate_list` parameter from `resolveProjectionExpressionNodeList` - Remove `__interpolate` wrapping logic from projection resolution - Remove construction of `interpolate_list` set in `resolveQuery`
maxjustus
added a commit
to maxjustus/ClickHouse
that referenced
this pull request
Mar 21, 2026
The `__interpolate` function was added in PR ClickHouse#93197 and subsequently reverted. This branch had code wrapping INTERPOLATE columns in `__interpolate` function calls, but the function implementation no longer exists after rebase. Changes: - Remove `interpolate_list` parameter from `resolveProjectionExpressionNodeList` - Remove `__interpolate` wrapping logic from projection resolution - Remove construction of `interpolate_list` set in `resolveQuery`
maxjustus
added a commit
to maxjustus/ClickHouse
that referenced
this pull request
Mar 28, 2026
The `__interpolate` function was added in PR ClickHouse#93197 and subsequently reverted. This branch had code wrapping INTERPOLATE columns in `__interpolate` function calls, but the function implementation no longer exists after rebase. Changes: - Remove `interpolate_list` parameter from `resolveProjectionExpressionNodeList` - Remove `__interpolate` wrapping logic from projection resolution - Remove construction of `interpolate_list` set in `resolveQuery`
maxjustus
added a commit
to maxjustus/ClickHouse
that referenced
this pull request
Mar 30, 2026
The `__interpolate` function was added in PR ClickHouse#93197 and subsequently reverted. This branch had code wrapping INTERPOLATE columns in `__interpolate` function calls, but the function implementation no longer exists after rebase. Changes: - Remove `interpolate_list` parameter from `resolveProjectionExpressionNodeList` - Remove `__interpolate` wrapping logic from projection resolution - Remove construction of `interpolate_list` set in `resolveQuery`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Prevent different interpolated columns from collapse into the same column in a block when interpolated columns are effectively aliases of the same column
closes #71858
closes #381
The source of the bug is that interpolated columns can be just aliases of another column and as a result they are resolved into that single column and during interpolation transform, rows for different interpolated columns are written into the same resulting column. Solved by introduction of internal
__interpolate()function which just returns its first argument (original column), but also accepts second argument (which is an alias of an interpolated column) which creates unique column (by introducing unique function's signature) disambiguating it from original.