avoid caching the partition key for non-deterministic functions#92844
Merged
avoid caching the partition key for non-deterministic functions#92844
Conversation
Contributor
|
Workflow [PR], commit [43af0d6] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-bugfix
Member
|
Can you please check bugfix check? Seems the test does not reproduce the bug |
kssenii
approved these changes
Jan 5, 2026
src/Storages/IPartitionStrategy.cpp
Outdated
|
|
||
| ColumnPtr HiveStylePartitionStrategy::computePartitionKey(const Chunk & chunk) | ||
| { | ||
| // Build Hive-style AST (already includes toString wrapping) |
Member
There was a problem hiding this comment.
btw as I remember /// is for comments and // is for commenting out code parts according to style.md somewhere in doc
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
In the S3 table engine, we should avoid caching the partition key if there are non-deterministic functions.
Documentation entry for user-facing changes