Merged
Conversation
Contributor
PedroTadim
changed the title
thevar1able
approved these changes
Dec 18, 2025
tests/queries/0_stateless/03704_rmv_logging_internal_queries.sh
Outdated
Show resolved
Hide resolved
azat
reviewed
Dec 18, 2025
Member
Author
|
@antaljanosbenjamin can you give a look at this again? |
tests/queries/0_stateless/03704_rmv_logging_internal_queries.sh
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes
For 03759_marks_cache_events:
I think the issue was due to enabled async inserts; the first select queries didn't see the part flushed into the storage yet. Also added defensive lines for the DETACH.
For 03704_rmv_logging_internal_queries:
Just check if inserts were logged; there could be other materialized views from other tests running in parallel, also doing inserts.
Closes #91973
Closes #92284