Open
Conversation
Contributor
|
Workflow [PR], commit [220603a] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-improvement
yariks5s
changed the title
jkartseva
approved these changes
Dec 19, 2025
tests/queries/0_stateless/03765_case_insensitive_identifiers.sql
Outdated
Show resolved
Hide resolved
rschu1ze
reviewed
Dec 21, 2025
…om/ClickHouse/ClickHouse into yarik/case-insensitive-identifiers
novikd
reviewed
Dec 23, 2025
Member
novikd
left a comment
novikd
left a comment
There was a problem hiding this comment.
PR requires changes. Please, consider:
- Filling table expression data in case-insensitive way in QueryAnalyzer.
- Maybe aliases also should work in case-insensitive pashion.
- Other databases may use upper-case -- may be we should as well.
…om/ClickHouse/ClickHouse into yarik/case-insensitive-identifiers
…om/ClickHouse/ClickHouse into yarik/case-insensitive-identifiers
yariks5s
changed the title
Resolved conflicts: - `IdentifierNode.cpp`: adapted `setQuoteStyles` to use `make_intrusive` instead of `std::make_shared` - `QueryAnalyzer.cpp`: combined PR's `is_part_double_quoted` tracking with master's `allow_to_resolve_niladic_functions` parameter; added both new extern settings - `Settings.h`: added both `CaseInsensitiveNames` and `DeduplicateInsertMode` setting types - `ExpressionElementParsers.cpp`: adapted `setQuoteStyle`/`setQuoteStyles` calls to use `make_intrusive`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Provides an ability to use all identifiers (database, table, column) case-insensitively under the setting. Used for SQL-standard compatibility: when the setting is enabled, all identifiers are resolved to lowercase, so identifiers that are different only by case will be considered the same. Closes #33935
Documentation entry for user-facing changes