Skip to content

Simplier alter prepare#9227

Merged
alexey-milovidov merged 8 commits intomasterfrom
simplier_alter_prepare
Feb 20, 2020
Merged

Simplier alter prepare#9227
alexey-milovidov merged 8 commits intomasterfrom
simplier_alter_prepare

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Feb 19, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Improved ALTER MODIFY/ADD queries logic. Now you cannot ADD column without type, MODIFY default expression doesn't change type of column and MODIFY type doesn't loose default expression value. Fixes #8669.

Documentation can be found in Changelog entry.

@alesapin alesapin added doc-alert pr-bugfix Pull request with bugfix, not backported by default pr-improvement Pull request with some product improvements labels Feb 19, 2020
@alesapin
Copy link
Copy Markdown
Member Author

Why tests for alters don't have word alter in their names?

@alexey-milovidov alexey-milovidov merged commit 4433947 into master Feb 20, 2020
abyss7 pushed a commit that referenced this pull request Feb 21, 2020
Simplier alter prepare

(cherry picked from commit 4433947)
@abyss7 abyss7 added the v20.1 label Feb 21, 2020
nikitamikhaylov added a commit that referenced this pull request Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent ALTER behaviour.

3 participants