Fix PartialSortingTransform by expanding column to full#9151
Closed
azat wants to merge 3 commits intoClickHouse:masterfrom
Closed
Fix PartialSortingTransform by expanding column to full#9151azat wants to merge 3 commits intoClickHouse:masterfrom
azat wants to merge 3 commits intoClickHouse:masterfrom
Conversation
Member
|
@KochetovNicolai I thought PartialSortingTransform should leave const columns as is. Otherwise we will have performance degradation. Also look at MSan test. |
Member
It's true. The problem should have been in pipeline itself. |
Member
|
Msan points to |
Member
|
@KochetovNicolai have you tried to build with with |
alexey-milovidov
added
the
st-discussion
KochetovNicolai
added a commit
that referenced
this pull request
Feb 20, 2020
Member
|
The issue was accidentially fixed in #8929 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix PartialSortingTransform by expanding column to full