Fix three assertion failures in InverseDictionaryLookupPass#91460
Merged
nihalzp merged 5 commits intoClickHouse:masterfrom Dec 16, 2025
Merged
Fix three assertion failures in InverseDictionaryLookupPass#91460nihalzp merged 5 commits intoClickHouse:masterfrom
InverseDictionaryLookupPass#91460nihalzp merged 5 commits intoClickHouse:masterfrom
Conversation
InverseDictionaryLookupPassInverseDictionaryLookupPass
Contributor
|
Workflow [PR], commit [0ad09e0] Summary: ❌
|
InverseDictionaryLookupPassInverseDictionaryLookupPass
KochetovNicolai
approved these changes
Dec 16, 2025
Member
|
|
Member
Member
Author
|
Seems like caused by a flaky test. |
Merged
via the queue into
ClickHouse:master
with commit Dec 16, 2025
488dbf4
249 of 256 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following queries has assertion failure:
I assumed dictionary arguments would be validated before the pass; but it's not the case always.
The following two also have logical error because the return type of the original node and the replacement expression did not match (e.g.
Nullable(UInt8)vsUInt8).Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes